Run Diktat from CLI using glob (**/*) paths #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: This change is intended to test that ktlint (0.47+) is indeed capable of parsing Ant wildcard patterns (`**/*.kt` etc.). Fixes #1397.
0x6675636b796f75676974687562
requested review from
petertrr,
orchestr7,
kgevorkyan and
nulls
Codecov Report
@@ Coverage Diff @@
## master #1544 +/- ##
=========================================
Coverage 82.09% 82.09%
Complexity 2306 2306
=========================================
Files 112 112
Lines 7793 7793
Branches 2011 2011
=========================================
Hits 6398 6398
Misses 481 481
Partials 914 914
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nulls
approved these changes
Oct 31, 2022
|
maybe move it to smoke test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This change is intended to test that ktlint (0.47+) is indeed capable of parsing Ant wildcard patterns (
**/*.ktetc.).Fixes #1397.